fix: use MessageData.tagged to mark maxHeartbeat exceptions
#5566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Oct 1, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Oct 1, 2024
leanprover-community-bot
added
the
builds-mathlib
kmill
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
@kim-em This PR fixes something I broke in #4781; I didn't realize that isMaxHeartbeat checked for the exact text of the error message, and it's an important part of the exception handling architecture. We probably should backport this to 4.12. At least the system normally avoids bumping into heartbeat errors, so it's not the highest of priorities, but users running into heartbeat errors might see confusing states.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5565, by using tags instead of trying to string match on a
MessageData. This ends up reverting some unwanted test output changes from #4781 too.This changes
isMaxRecDepthfor good measure too.This was a regression in Lean 4.11.0, so may be worth backporting to 4.12.x, if not also 4.11.x.